VizPanel: Allow clearing default values#1255
Open
bfmatei wants to merge 3 commits into
Open
Conversation
bfmatei
requested review from
Sergej-Vlasov,
Copilot,
dprokop,
ivanortegaalba,
oscarkilhed and
torkelo
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables clearing default values in VizPanel options by refactoring the options merging logic. Previously, attempts to clear default values had no effect because the merge with default values would override the cleared state.
- Removed the
isAfterPluginChangeparameter fromonOptionsChangeas it wasn't being used correctly - Moved the
getPanelOptionsWithDefaultscall fromonOptionsChangeto the plugin change logic where it's actually needed - Simplified the options change handling to preserve cleared values instead of always merging with defaults
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
torkelo
reviewed
Sep 24, 2025
Collaborator
torkelo
left a comment
torkelo
left a comment
There was a problem hiding this comment.
should we update unit test for this scenario?
Contributor
Author
|
@torkelo - absolutely! Fixed the test and added an additional one. |
bfmatei
added
minor
torkelo
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grafana/grafana#91600
This PR allows clearing default values in panel options. Currently trying to remove a default value would result in no actual change.
A little explanation about the code:
getPanelOptionsWithDefaultsfunctiononOptionsChangewas acceptingisAfterPluginChangeas a parametergetPanelOptionsWithDefaultswhere it was used, it was not affectingoptionsbutfieldConfig. This was removedgetPanelOptionsWithDefaultscall was removed completely fromonOptionsChange📦 Published PR as canary version:
6.40.0--canary.1255.18001595104.0✨ Test out this PR locally via:
npm install @grafana/scenes-react@6.40.0--canary.1255.18001595104.0 npm install @grafana/scenes@6.40.0--canary.1255.18001595104.0 # or yarn add @grafana/scenes-react@6.40.0--canary.1255.18001595104.0 yarn add @grafana/scenes@6.40.0--canary.1255.18001595104.0